Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep /sdcard clean #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Fingalzzz
Copy link

Move /sdcard/EnergizedProtection to /sdcard/Documents/EnergizedProtection.

@AdroitAdorKhan
Copy link
Collaborator

@AvinashReddy3108 I don't think this would be good idea to put our directory there. Because our directory isn't just a placebo! I'm not sure if users would like to go to /sdcard/Documents/EnergizedProtection/ everytime, for adding some domains or modifying the config file. What do you say about this?

@AdroitAdorKhan
Copy link
Collaborator

@Fingalzzz our module isn't the only one which is taking a folder place in your /sdcard, is it? Don't you have any other app/module/recovery taking a folder space there?

@Fingalzzz
Copy link
Author

@AdroitAdorKhan No, there's no other folders in my /sdcard except the default ones. Actually, I'm using an app/riru-module to redirect folders in /sdcard to where they should be. There must have some reasons that Android set the folder /sdcard/Documents to be default. IMHO, it's the place to put some backup files or config files. For my own interests, I'd prefer to put EnergizedProtection folder there, since I've got other config files there and it's easier for me to manage. For other users, go to /sdcard/Documents/EnergizedProtection rather than /sdcard/EnergizedProtection just need a single click. I don't think that costs much. What do you say?

@AvinashReddy3108 AvinashReddy3108 force-pushed the master branch 2 times, most recently from 7fd8f2f to f085009 Compare October 16, 2020 04:15
@DerGoogler
Copy link

/sdcard/Documents is a public directory. Everyone can access it, even apps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants